feat(openai-agents): Truncate long messages #5141
Open
+70
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #5141 +/- ##
==========================================
- Coverage 84.02% 83.99% -0.03%
==========================================
Files 180 180
Lines 18223 18230 +7
Branches 3233 3235 +2
==========================================
+ Hits 15311 15313 +2
- Misses 1922 1924 +2
- Partials 990 993 +3
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| SPANDATA.GEN_AI_REQUEST_MESSAGES, | ||
| messages_data, | ||
| unpack=False, | ||
| ) |
There was a problem hiding this comment.
Bug: Empty messages no longer set span data
When request_messages is an empty list, truncate_and_annotate_messages returns None, causing the span data to not be set. Previously, the code would set SPANDATA.GEN_AI_REQUEST_MESSAGES to an empty JSON array even when request_messages was empty. This behavioral change could break code expecting this field to always exist when messages are processed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-picked from #5049
Issues
Closes TET-1208
Reminders
tox -e linters.feat:,fix:,ref:,meta:)